Hi Debarsi, Thanks very much for looking at this. Debarshi 'Rishi' Ray wrote: >> I have uploaded a new version with all the non-Fedora stuff stripped >> out. Please take another look if you are able: >> > > Assuming that http://jpye.fedorapeople.org/sundials/sundials.spec is > the latest version of the spec file, here are my comments: > > 1. You should consult > https://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 > to pick the value for your BuildRoot. > OK, fixed > 2. Why are you invoking ./configure directly instead of using > '%configure' in the '%build' stanza? > OK, fixed (reason was related to the following, but %configure is still OK, so I use it now) > 3. Do you really need to use '%makeinstall' in the '%install' stanza? > Consult https://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 > Yes, SUNDIALS does not support the 'DESTDIR' thing AFAICT. > 4. Consult http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-d0dbcb7eec27622a21df280009c5b089b02f5bef > to fix your post[un] scriptlets. > OK, fixed > Finally have you filed a review request in Bugzilla? > Yes, https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249034 I have uploaded the updated files to the *NEW* location (don't have my fedorapeople key here) of: http://ascend.cheme.cmu.edu/ftp/jpye/ Cheers JP -- Fedora-maintainers mailing list Fedora-maintainers@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-maintainers -- Fedora-maintainers-readonly mailing list Fedora-maintainers-readonly@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-maintainers-readonly
