> I have uploaded a new version with all the non-Fedora stuff stripped > out. Please take another look if you are able: Assuming that http://jpye.fedorapeople.org/sundials/sundials.spec is the latest version of the spec file, here are my comments: 1. You should consult https://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 to pick the value for your BuildRoot. 2. Why are you invoking ./configure directly instead of using '%configure' in the '%build' stanza? 3. Do you really need to use '%makeinstall' in the '%install' stanza? Consult https://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 4. Consult http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-d0dbcb7eec27622a21df280009c5b089b02f5bef to fix your post[un] scriptlets. Finally have you filed a review request in Bugzilla? Happy hacking, Debarshi -- GPG key ID: 63D4A5A7 Key server: pgp.mit.edu -- Fedora-maintainers mailing list Fedora-maintainers@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-maintainers -- Fedora-maintainers-readonly mailing list Fedora-maintainers-readonly@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-maintainers-readonly
