Callum Lerwick wrote:
On Fri, 2006-12-29 at 11:19 -0500, Jesse Keating wrote:
hrm, you must wear at least 5 pieces of flair... Seriously, a rule like this
just encourages folks to check 5 things only and move on. If rules were set
in place to make 5 specific things mandatory, that's all that will be
checked. Lets not give reviewers a shortcut out. I'd be more in favor of a
rule that just says "items checked need to be listed out in the review before
building of the package will be allowed". Vague enough as to not give
reviewers a shortcut.
Which is the whole idea of my checklist. It follows the MUST list
basically point-for-point. (Some related stuff gets mushed together into
one item, like everything relating to %file lists, and directory/file
ownership.) Everything in the MUST list is a MUST, and thus... MUST be
checked.
And really, the list is primarily for *my* benefit. To make sure *I*
don't miss any of them. I don't know how anyone could keep track of all
that in their head. And since I'm keeping a checklist anyway, I might as
well post it in the review.
Regardless of whether the checklist is going to be used by everyone,
since many people like the idea and use one on their own anyway, it
would be better to add one to the review guidelines asap so that there
is a common reference point.
Rahul
--
Fedora-maintainers mailing list
Fedora-maintainers@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-maintainers
--
Fedora-maintainers-readonly mailing list
Fedora-maintainers-readonly@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-maintainers-readonly
