On Mon, 24 Feb 2020 17:29:07 +0100 Florian Weimer <fweimer@xxxxxxxxxx> wrote: > * stan: > > > I built my first 5.6 custom kernel from the src.rpm yesterday in > > F31. And my patch to enable the use of a daemon I run to gather > > entropy from an rtl2832 (atmospheric) and put it into the kernel to > > keep the entropy pool full failed. This has happened in the past, > > that's why I have to patch, but the interface was never removed > > before. If it has been removed, can you point me to the discussion > > that led to that decision. I haven't done a complete analysis yet, the changes are pretty extensive. But the marker that the callback used to trigger the daemon has been removed. - .procname = "read_wakeup_threshold", - .data = &random_read_wakeup_bits, - .maxlen = sizeof(int), - .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = &min_read_thresh, - .extra2 = &max_read_thresh, - }, This seems to have been replaced with hard-coded functions that read from specific sources (mouse, key strokes, hard drives, etc.) to gather system entropy. I wanted to see the rationale for the changes before I invested the time to see how it is all working together now, and how to insert my code without disrupting everything. This is a pretty critical part of the kernel (I would say vital), so I like to be sure that everything is making sense, and that it was vetted properly. I'm not an expert in this, so I could be reading it all wrong, but I want to investigate before I decide. The developer description of the changes and the reasoning behind them would be the place to start. Maybe the decision was that no one was using this interface, so it didn't make sense to keep it around (more code to rot, and threaten security). _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
