Re: FBR: 🎶if you liked it then you should've put a lock on it...🎶

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/25/2017 01:03 PM, Ralph Bean wrote:
> ... or even if you didn't like it, it still probably needs a lock.
> 
> /usr/local/bin/pagure-sync-bugzilla.py takes more than 24 hours to
> run, and it doesn't have a lock wrapper on it.  It needs one.
> 
>     diff --git a/roles/distgit/pagure/tasks/main.yml b/roles/distgit/pagure/tasks/main.yml
>     index 8cdf0b3..9079f06 100644
>     --- a/roles/distgit/pagure/tasks/main.yml
>     +++ b/roles/distgit/pagure/tasks/main.yml
>     @@ -228,7 +228,7 @@
>          user: root
>          minute: 0
>          hour: 18
>     -    job: /usr/local/bin/pagure-sync-bugzilla.py
>     +    job: /usr/bin/lock-wrapper pagure-sync-bugzilla "/usr/local/bin/pagure-sync-bugzilla.py"
>          cron_file: pagure-sync-bugzilla
>          state: present
>        when: env != 'staging'
> 
> Anyone for it?  Against it?

+1, but we should see if we can figure out why it was taking longer than
a day to run. ;(

kevin


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx

[Index of Archives]     [Fedora Development]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]

  Powered by Linux