How long is it taking to do a sync? And would it be better to schedule the cron job to be non-daily in that case? On 25 September 2017 at 16:03, Ralph Bean <rbean@xxxxxxxxxx> wrote: > ... or even if you didn't like it, it still probably needs a lock. > > /usr/local/bin/pagure-sync-bugzilla.py takes more than 24 hours to > run, and it doesn't have a lock wrapper on it. It needs one. > > diff --git a/roles/distgit/pagure/tasks/main.yml b/roles/distgit/pagure/tasks/main.yml > index 8cdf0b3..9079f06 100644 > --- a/roles/distgit/pagure/tasks/main.yml > +++ b/roles/distgit/pagure/tasks/main.yml > @@ -228,7 +228,7 @@ > user: root > minute: 0 > hour: 18 > - job: /usr/local/bin/pagure-sync-bugzilla.py > + job: /usr/bin/lock-wrapper pagure-sync-bugzilla "/usr/local/bin/pagure-sync-bugzilla.py" > cron_file: pagure-sync-bugzilla > state: present > when: env != 'staging' > > Anyone for it? Against it? > > _______________________________________________ > infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx > To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx > -- Stephen J Smoogen. _______________________________________________ infrastructure mailing list -- infrastructure@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to infrastructure-leave@xxxxxxxxxxxxxxxxxxxxxxx
