On Wed, 2007-03-07 at 08:14 +0100, Ralf Corsepius wrote: > On Mon, 2007-03-05 at 16:30 -0600, Tom 'spot' Callaway wrote: > > > Thoughts? Suggestions are welcomed. > > MUSTFIX: > > 1. There is a bug in your spec, which rendering the rpms > non-installable: > ... > Requires: perl(ExtUtils::Embed), perl(ExtUtils-MakeMaker) Yep. Robin caught that one today too. Sorry bout that. :/ > Both these Requires are superfluous, furthermore > perl(ExtUtils-MakeMaker) is wrong. > > The perl(ExtUtils-MakeMaker) is the show-stopper. > > 2. You missed to move enc2xs to devel: > > /usr/bin/enc2xs depends on /usr/lib/perl5/5.8.8/Encode/Makefile_PL.e2x > which indirectly depends on EU::MakeMaker > => move enc2xs to *-devel OK. > SHOULDFIX: > 3. Several man-pages corresponding to tools having been moved from > perl to perl-devel are missing from *-devel OK. > REMARK: > 4. I don't understand why you moved Test::Harness. > Besides that Test::Harness probably belongs into *-devel, because it's a > Test:: module and therefore probably is not being used at run-time at > all, I don't see any pressing requirement to move it now. I moved it because it seemed an obvious candidate for -devel. Also, when I was separating packages into their own packages, -CPAN needed a much newer Test::Harness. What about the other Test:: items? Do you think they are safe to move to -devel? Or should we just put all of Test:: in base for now? ~spot
