On Wed, May 02, 2007 at 02:28:34PM -0600, Charles Coffing wrote: > There is a nasty typo in virt manager, which is masked by a catch-all > "except:" clause. This error could cause unnecessary VNC connection > failures. Hmm, surprised I've never noticed that error before. > The bad line is actually completely useless, since disconnect_from_host > correctly sets self.client=None. The preceeding "if" is also useless, > since disconnect_from_host handles the case where self.client is None. > The attached patch deletes all this unnecessary junk. Thanks, will apply shortly if Hugh's not already done so. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
