There is a nasty typo in virt manager, which is masked by a catch-all "except:" clause. This error could cause unnecessary VNC connection failures. The bad line is actually completely useless, since disconnect_from_host correctly sets self.client=None. The preceeding "if" is also useless, since disconnect_from_host handles the case where self.client is None. The attached patch deletes all this unnecessary junk. Signed-off-by: Charles Coffing <ccoffing@xxxxxxxxxx>
Attachment:
virtman-typo.diff
Description: Binary data
