On Monday, May 23, 2022 11:18:38 PM CDT Orion Poplawski wrote:
> I've been coming to the thinking that naming the SRPMS
> python3X-%{srcname}-epel is a better choice. This makes modifying
> original Fedora specs simpler.
I think that makes sense, especially considering that these packages will not
be built for Fedora.
> See https://fedoraproject.org/wiki/EPEL/Python3X
Here is some feedback:
First, aren't we trying to move off the wiki? Wouldn't this be a better
candidate for the EPEL docs on docs.fp.o?
> separate Python 3 minor versions in EPEL 8 are packaged as separate python3X
> (currently python38) packages to allow for independent versions for each
> Python version.
There is also python39.
> == Issues ==
> * How to handle %{py3_dist} macro?
I believe `%{py3_dist}` works properly if you add `%global python3_pkgversion
3X`.
When I built ansible-5 for Python 3.8, I just ran `:%s python3-/python%
{python3_pkgversion}-/` and added `%global python3_pkgversion 38`. `%
{python3_pkgversion}` is set to 3
by default. I would recommend doing that in your example instead of hardcoding
`python38`.
> == Example Spec ==
>
> <pre>
[...]
> %global sum An example python module
I don't think there's any point to have a %sum macro when you can use `%
{summary}` in subpackage definitions. Admittedly, this is more of a packaging
nitpick than a comment related to the issue at hand :D.
> %global __python3 /usr/bin/python3.8
I think it's better to add `Requires: python%{python3_pkgversion}-rpm-macros`.
To be fair, they both do effectively the same thing: set %__python3 to the
correct value. In any case, I submitted https://src.fedoraproject.org/rpms/
epel-rpm-macros/pull-request/44 so neither should be necessary.
> %check
> %{__python3} setup.py test
I was going to suggest using `%pytest`, but then I remembered that https://
pagure.io/releng/issue/10679 is still outstanding :(.
> %files -n python38-%{srcname}
[...]
> %{python3_sitelib}/*
Globs like this are against the Python Packaging Guidelines.
--
Thanks,
Maxwell G (@gotmax23)
Pronouns: He/Him/HisAttachment:
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ epel-devel mailing list -- epel-devel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to epel-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/epel-devel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
