Re: [PATCH 2/2] Use ksdata.timezone and timezone module instead of anaconda.timezone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-06-18 at 11:17 -0400, Chris Lumens wrote:
> > +    try:
> > +        with open(os.path.normpath(root + "/etc/sysconfig/clock"), "w") as file_:
> 
> Maybe I'm just being too picky, but there's something about a name with
> a trailing underscore that just makes me cringe.
It is what PEP 8 says about names conflicting with Python keywords [1],
but I can of course use something else.

Do these patches look good otherwise?

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux