On Mon, 2012-06-18 at 14:55 -0400, Chris Lumens wrote: > > > This is a kind of weird phrasing. Why don't you use hasattr instead? > > > > This also catches the case where it has the attribute but the value is > > not set to anything useful. This instance may be an unnecessary hack. It > > was added to deal with CreateNewPage instances not having a _members > > attribute. > > self._members is added by Page.__init__, which CreateNewPage derives > from. So there should always be a self._members. However it may very > well be an empty list. That was also sloppy on my part. CreateNewPage doesn't ever call the Page constructor AFAICT. Maybe that's the correct fix. > > - Chris > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
