Re: [PATCH 7/7] Clean up and simplify some things in the custom storage spoke.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > This is a kind of weird phrasing.  Why don't you use hasattr instead?
> 
> This also catches the case where it has the attribute but the value is
> not set to anything useful. This instance may be an unnecessary hack. It
> was added to deal with CreateNewPage instances not having a _members
> attribute.

self._members is added by Page.__init__, which CreateNewPage derives
from.  So there should always be a self._members.  However it may very
well be an empty list.  That was also sloppy on my part.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux