On Tue, Jun 12, 2012 at 11:12:42AM +0200, Vratislav Podzimek wrote: > On Mon, 2012-06-11 at 10:24 -0700, Brian C. Lane wrote: > > On Mon, Jun 11, 2012 at 03:39:05PM +0200, Vratislav Podzimek wrote: > > > > This looks pretty good to me, I think it addresses all of clumens' > > concerns. > > > > One small thing: > > > > > + def __str__(self): > > > + retval = KickstartCommand.__str__(self) > > > + > > > + retval += "# System timezone\n" > > > + retval += "timezone " + self._getArgsAsStr() + "\n" > > > > This will have an extra space between timezone and the first argument. > > As long as all the return values from _getArgsAsStr start with a space > > we can remove the one from "timezone " > Actually the first argument is the timezone with no space, so it is ok. > Test checking the spacing failed when I removed the space. :) Oops, I missed that. Now we know the tests work :) -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgpSzrwrJ3oLD.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
