Hello Vratislav, Vratislav Podzimek <vpodzime@xxxxxxxxxx> writes: > On Mon, 2012-06-11 at 19:29 +0300, Adrian Perez wrote: > >> Certain compilers may spit out a huge amount of warnings about >> missing prototypes, or even fail to compile grubby.c if they >> default to the C99 standard. This adds the missing prototypes >> at the beginning of the source file, also marking the functions >> as static -- they are not going to be used anywhere else after >> all. > > Wouldn't it be better to put these in a grubby.h file and then include > it? I know that being static they are not going to be used anywhere > else, but we still could have the prototypes in the header file where > they belong. I think it would make sense, but I just wanted to make the less modifications as possible to make it build here. I can rework the patch, splitting a grubby.h file. Will send the updated patch set later to the list. Thanks for the feedback, -Adrian -- Adrian Perez <aperez@xxxxxxxxxx> - Sent from my toaster Igalia - Free Software Engineering
Attachment:
pgpRFprcZPzvg.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
