On Mon, Jun 11, 2012 at 03:39:05PM +0200, Vratislav Podzimek wrote: This looks pretty good to me, I think it addresses all of clumens' concerns. One small thing: > + def __str__(self): > + retval = KickstartCommand.__str__(self) > + > + retval += "# System timezone\n" > + retval += "timezone " + self._getArgsAsStr() + "\n" This will have an extra space between timezone and the first argument. As long as all the return values from _getArgsAsStr start with a space we can remove the one from "timezone " -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
Attachment:
pgphFZtrf0PM4.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
