Re: [PATCH 5/6] Enable package installation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/pyanaconda/install.py b/pyanaconda/install.py
> index 24d3098..e029168 100644
> --- a/pyanaconda/install.py
> +++ b/pyanaconda/install.py
> @@ -41,6 +41,7 @@ def doInstall(storage, payload, ksdata, instClass):
>      steps = len(storage.devicetree.findActions(type="create", object="format")) + \
>              len(storage.devicetree.findActions(type="resize", object="format")) + \
>              len(storage.devicetree.findActions(type="migrate", object="format"))
> +    steps += 2  # package install setup, package install
>      progress.progressQ.put((progress.PROGRESS_CODE_INIT, [steps]))
>  

My original thinking was that we'd have a step for every single package
to be installed.  That provides the user with some knowledge of how far
through the process they are, but it makes partitioning almost
irrelevant when a lot of packages are in the set.

Things we can do:

(1) What you've got.

(2) What I was thinking.

(3) What you've got, but supplement the text somehow to show how many
packages through the process you are.

(4) Fill the progress bar up to 100% with partitioning, then go back to
0% when packaging starts and fill it back up on a per-package basis.

(5) ???

>  default_repos = [productName.lower(), "rawhide"]
>  
> @@ -797,6 +797,8 @@ reposdir=/etc/yum.repos.d,/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/t
>          log.info("preparing transaction")
>          log.debug("initialize transaction set")
>          with _yum_lock:
> +            progressQ.put((PROGRESS_CODE_MESSAGE,
> +                           [_("Starting installation process")]))
>              self._yum.initActionTs()
>  
>              log.debug("populate transaction set")

I wish there were a better way to hide this ugliness.  Maybe at the
least, I can add helper functions to progress.py for each PROGRESS_CODE_
value so you can just pass the single message argument or whatever.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux