Hi,
On 06/11/2010 05:46 PM, Brian C. Lane wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/11/2010 03:36 AM, Ales Kozumplik wrote:
Hi Brian,
you'll need to revert this patch and come up with another fix. The
problem is that on rawhide the timezone property is referenced as early
as anaconda:855, that is before the storage.storageInitialized()
function was called (it is normally called as a dispatch step see
dispatch.py). The hasWindows() method in bootloader.py that the property
calls depends on the anconda.storage object to be initialized already so
it can inspect the existing partitions in the system.
Thanks. I made the patch on f13 and cherry-picked over to rawhide since
I wasn't able to get a boot.iso to run. I'll try again today.
Hans and me thought it would be reasonable to do this instead:
<hansg> timezone_gui.py needs to keep track if its called the first time
or not and depepending on that re-use the old value or call hasWindows()
I'm not sure I understand the suggestion, since that would still call
hasWindows at the wrong point,
Not if you put the hasWindows call in the getScreen method which does not
get called until the screen is shown, at which point the storage scanning
is already done.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
