-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/11/2010 03:36 AM, Ales Kozumplik wrote: > Hi Brian, > > you'll need to revert this patch and come up with another fix. The > problem is that on rawhide the timezone property is referenced as early > as anaconda:855, that is before the storage.storageInitialized() > function was called (it is normally called as a dispatch step see > dispatch.py). The hasWindows() method in bootloader.py that the property > calls depends on the anconda.storage object to be initialized already so > it can inspect the existing partitions in the system. > Thanks. I made the patch on f13 and cherry-picked over to rawhide since I wasn't able to get a boot.iso to run. I'll try again today. > Hans and me thought it would be reasonable to do this instead: > <hansg> timezone_gui.py needs to keep track if its called the first time > or not and depepending on that re-use the old value or call hasWindows() > I'm not sure I understand the suggestion, since that would still call hasWindows at the wrong point, and it is already checking to see if the object has been initialized. > Contrary to what I originally thought, your patch doesn't cause the > traceback in 592860. But that's a similar initialization order issue, > I'll post a patch for that soon. > Whew! ;) I'll get a rawhide boot.iso working and then re-visit this. - -- Brian C. Lane <bcl@xxxxxxxxxx> Red Hat / Port Orchard, WA -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Remember Lexington Green! iQEVAwUBTBJaXhF+jBaO/jp/AQIgVQf9E8KEWJ7Srxbwa4qYb2aitEypj/9qzpAx mXnjHkKCx2Dif2JN70vL2Fjk+VwTympfMxZV2c3xr2PxhFTlaDZ9uKz3yczbowJ/ EOLg1CpN3iQnVHnAaWGVosVtpW5ro92xv+DO8H1RquJgJ3zROUiiVpd5EfvzplFN sbqY/nR8V4KjlvjA8c8bK/YuM3piNm0sgJFrWCCQ3wAAw+JITF6pecWhLzEN3j0F /TxBkogNPQNpiw0VKQesYhqdVq6cQgC1F/076IrJo+zXBBYogN2A4hYImKGX3nEu LrxvgPAdguNNIq2BSkSI3/EB2VVnzfSYTGldCDA9Mu+ceu7ngkErTw== =X640 -----END PGP SIGNATURE----- _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
