Re: [PATCH 6/8] Add isDisk property to MDRaidArrayDevice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 01/22/2010 05:21 PM, David Lehman wrote:
On Fri, 2010-01-22 at 10:24 +0100, Hans de Goede wrote:
And make it return True for BIOS RAID sets (but not for containers).
---
  storage/devices.py |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/storage/devices.py b/storage/devices.py
index bddf055..52e0466 100644
--- a/storage/devices.py
+++ b/storage/devices.py
@@ -2836,6 +2836,10 @@ class MDRaidArrayDevice(StorageDevice):
      def partitionable(self):
          return self.devices and self.devices[0].type == "mdcontainer"

+    @property
+    def isDisk(self):
+        return self.devices and self.devices[0].type == "mdcontainer"
+

It's better if you make this always return a boolean. (use
len(self.devices) != 0)


Ok I'll fix this before committing

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux