Re: [PATCH 2/7] Fix MDRaidArrayDevice mediaPresent to not depend on paritioned state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/storage/devices.py b/storage/devices.py
> index 93da0cf..f21e730 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -2808,15 +2808,15 @@ class MDRaidArrayDevice(StorageDevice):
>  
>      @property
>      def mediaPresent(self):
> -        present = None
> -        if self.partitioned:
> -            # Even if stopped/deactivated we still want to show up in
> -            # storage.disks
> -            present = True
> -        else:
> -            present = self.partedDevice is not None
> +        # Containers should not get any format handling done
> +        # (the device node does not allow read / write calls)
> +        if self.type == "mdcontainer":
> +            return False
> +        # BIOS RAID sets should show as present even when teared down
> +        if self.devices and self.devices[0].type == "mdcontainer":
> +            return True
>  
> -        return present
> +        return self.partedDevice is not None
>  
>      @property
>      def model(self):

This definitely seems more correct, in that the presence of partitioning
shouldn't matter for mediaPresent.  Honestly, I'm not sure when we
started making mediaPresent meaningful for things other than removable
devices, or when we started using it to decide that things should be
present in the UI.  However, I'd argue that both uses are incorrect and
confusing given the name of the method.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux