Hi,
On 01/21/2010 07:47 PM, Chris Lumens wrote:
OEM's routinely ship systems with BIOS RAID enabled, so we should support
these in basic mode to.
I really dislike this - you're redefining what "basic" means, basically
saying "it doesn't matter whether you chose basic or not, you're still
getting RAID devices to look at."
Erm no I'm redefining what simple means, note that there are no tabs in simple mode
so the word "Basic" is not used.
Also quoting from the screen where one can choose simple or complex storage:
self.buttonGroup.addEntry("simple", _("Basic Storage Devices"),
descr=_("Installs or upgrades to typical types "
"of storage devices. If you're not sure "
"which option is right for you, this is "
"probably it."))
self.buttonGroup.addEntry("complex", _("Specialized Storage Devices"),
descr=_("Installs or upgrades to devices such as "
"Storage Area Networks (SANs) or mainframe
"attached disks (DASD), usually in an "
"enterprise environment"))
Notice that simple is for "typical types of storage", and BIOS RAID is
quit common, iow typical. It surely is not:
"Storage Area Networks (SANs) or mainframe attached disks (DASD)"
@@ -406,8 +410,8 @@ class FilterWindow(InstallWindow):
self._cachedMPaths.extend(mpaths)
self._cachedRaidDevices.extend(raids)
- def _makeBasic(self):
- np = NotebookPage(self.store, "basic", self.xml, Callbacks(self.xml))
+ def _makeBasic(self, callbacks):
+ np = NotebookPage(self.store, "basic", self.xml, callbacks(self.xml))
np.ds.addColumn(_("Model"), MODEL_COL)
np.ds.addColumn(_("Capacity"), CAPACITY_COL)
@@ -505,11 +509,11 @@ class FilterWindow(InstallWindow):
self.store.set_sort_column_id(MODEL_COL, gtk.SORT_ASCENDING)
if anaconda.id.simpleFilter:
- self.pages = [self._makeBasic()]
+ self.pages = [self._makeBasic(SimpleCallbacks)]
self.notebook.set_show_border(False)
self.notebook.set_show_tabs(False)
else:
- self.pages = [self._makeBasic(), self._makeRAID(),
+ self.pages = [self._makeBasic(Callbacks), self._makeRAID(),
self._makeMPath(), self._makeOther(),
self._makeSearch()]
Please preserve the fact that right now, all _makeWhatever methods take
the same number of arguments.
Done, new patch coming up.
Regards,
Hans
p.s.
Is there any reason why the screen is the first screen after the welcome screen,
IMHO it should be directly before the partition type screen, so after the
root pass one. This makes it easier to go back when you find out you forgot to
check some disk you want, and it feels more logical to group all the storage
screens together.
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
