> OEM's routinely ship systems with BIOS RAID enabled, so we should support
> these in basic mode to.
I really dislike this - you're redefining what "basic" means, basically
saying "it doesn't matter whether you chose basic or not, you're still
getting RAID devices to look at." It further means that if you bounce
back and forth between basic and advanced, RAID devices will move from
one tab to another. That's really not very easy to explain to a user.
> @@ -406,8 +410,8 @@ class FilterWindow(InstallWindow):
> self._cachedMPaths.extend(mpaths)
> self._cachedRaidDevices.extend(raids)
>
> - def _makeBasic(self):
> - np = NotebookPage(self.store, "basic", self.xml, Callbacks(self.xml))
> + def _makeBasic(self, callbacks):
> + np = NotebookPage(self.store, "basic", self.xml, callbacks(self.xml))
>
> np.ds.addColumn(_("Model"), MODEL_COL)
> np.ds.addColumn(_("Capacity"), CAPACITY_COL)
> @@ -505,11 +509,11 @@ class FilterWindow(InstallWindow):
> self.store.set_sort_column_id(MODEL_COL, gtk.SORT_ASCENDING)
>
> if anaconda.id.simpleFilter:
> - self.pages = [self._makeBasic()]
> + self.pages = [self._makeBasic(SimpleCallbacks)]
> self.notebook.set_show_border(False)
> self.notebook.set_show_tabs(False)
> else:
> - self.pages = [self._makeBasic(), self._makeRAID(),
> + self.pages = [self._makeBasic(Callbacks), self._makeRAID(),
> self._makeMPath(), self._makeOther(),
> self._makeSearch()]
Please preserve the fact that right now, all _makeWhatever methods take
the same number of arguments.
- Chris
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
