Re: [PATCH] Show call depth with spaces in log_method_call()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/18/2010 11:52 AM, Ales Kozumplik wrote:
> 
>> They don't seem to get all that bad in general, especially in our new
>> KMS world of tiny fonts.  I have another patch to void this problem, but
>> it's a bit of a hack - basically, I make log_method_call() remember the
>> depth of the shortest stack it's ever seen, and subtract that number from
>> len(stack).  Then I added a call to log_method_call() call at the
>> beginning
>> of DeviceTree.__init__(), since that appears to be in every call path
>> that
>> ever calls it, or at least the vast majority of them.
>>
>> As I said, a bit of a hack.
> 
> Let's wait until either we can see an example where it looks terrible or
> someone else starts to complain. Then we can use the hack or perhaps
> come up with something more systematic.

Yeah - that's why I didn't post that one for /review/ ;)

-- 
        Peter

All parts should go together without forcing. You must remember that
the parts you are  reassembling were disassembled by you.  Therefore,
if you can't get them together again, there must be a reason. By all
means, do not use a hammer.
		-- IBM maintenance manual, 1925

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux