On Mon, Sep 21, 2009 at 03:30:56PM -0400, Chris Lumens wrote:
> > diff --git a/iw/partition_gui.py b/iw/partition_gui.py
> > index ee69f85..8c0f714 100644
> > --- a/iw/partition_gui.py
> > +++ b/iw/partition_gui.py
> > @@ -975,6 +975,9 @@ class PartitionWindow(InstallWindow):
> > """
> > device = self.tree.getCurrentDevice()
> > if not device:
> > + self.intf.messageWindow(_("Unable To Delete"),
> > + _("You must select a device to delete"),
> > + custom_icon="error")
> > return
> > if device.format.type == "disklabel":
> > if doClearPartitionedDevice(self.intf,
>
> Why do we want to pop up a dialog instead of just have the button be a
> no-op if no device is chosen? In general, we don't really follow one
> way or the other in anaconda with any consistency. It's probably time
> for us to decide and follow that choice all the way through.
I just want to give the user some feedback. Instead of him (the user)
being confused as to what might have been done after pressing the
button, we now tell him "Nothing was done because you have not chosen a
device". IMO, it increses the context information that the user needs
for a good experience.
Regards.
>
> - Chris
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
Attachment:
pgpuuL4Ser48a.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
