On Thu, Sep 17, 2009 at 05:18:07PM -1000, David Cantrell wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Looks fine. Same comment here about the isNew parameter, but that's probably
> how it was before you started working on these UI patches. Given the amount
> of work involved with these patches, I think it makes sense to clean up isNew
> and make it a real boolean.
Seems a good idea. And it gives me the change to further get rid of the
\t in the code.
>
> On Wed, 16 Sep 2009, Joel Granados Moreno wrote:
>
>> * iw/partition_gui.py (createCB): New function. All the create requests
>> will pass through this function. It pops up a dialog that presents the
>> different creat options to the user. Use the new storage/partitioning.py
>> function (hasFreeDiskSpace).
>> ---
>> iw/partition_gui.py | 192 ++++++++++++++++++++++++++++++++++++++++++++++++---
>> 1 files changed, 183 insertions(+), 9 deletions(-)
>>
...
>> @@ -1361,13 +1533,15 @@ class PartitionWindow(InstallWindow):
>> buttonBox = gtk.HButtonBox()
>> buttonBox.set_layout(gtk.BUTTONBOX_SPREAD)
>>
>> - ops = ((_("Ne_w"), self.newCB),
>> + ops = ((_("_Create"), self.createCB),
>> (_("_Edit"), self.editCB),
>> (_("_Delete"), self.deleteCB),
>> - (_("Re_set"), self.resetCB),
>> - (_("R_AID"), self.makeraidCB),
>> - (_("_LVM"), self.makeLvmCB))
>> -
>> + (_("Re_set"), self.resetCB))
>> +
>> +# (_("_Partition"), self.makepartCB),
>> +# (_("R_AID"), self.makeraidCB),
>> +# (_("_LVM"), self.makeLvmCB))
>> +
>> for label, cb in ops:
>> button = gtk.Button(label)
>> buttonBox.add (button)
>>
>
> - -- David Cantrell <dcantrell@xxxxxxxxxx>
> Red Hat / Honolulu, HI
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkqy++8ACgkQ5hsjjIy1Vknc5wCfUfXooOwzJNbeaUkiCmLx4Gwm
> UHsAn15b2bQpQuB9cptXC6nCar9swYu9
> =P1+J
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
Attachment:
pgpxtQKKXUL9G.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
