Re: [PATCH 07/30] Reorganize the Customization screen a little.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 21, 2009 at 03:34:32PM -0400, Chris Lumens wrote:
> > diff --git a/iw/partition_gui.py b/iw/partition_gui.py
> > index 3c67aa3..25e5de8 100644
> > --- a/iw/partition_gui.py
> > +++ b/iw/partition_gui.py
> > @@ -1427,7 +1427,8 @@ class PartitionWindow(InstallWindow):
> >  
> >          # operational buttons
> >          buttonBox = gtk.HButtonBox()
> > -        buttonBox.set_layout(gtk.BUTTONBOX_SPREAD)
> > +        buttonBox.set_spacing(10)
> > +        buttonBox.set_layout(gtk.BUTTONBOX_END)
> >  
> >          ops = ((_("_Create"), self.createCB),
> >                 (_("_Edit"), self.editCB),
> 
> The GNOME HIG recommends using multiples of 6 for spacing:
> 
>    http://library.gnome.org/devel/hig-book/stable/design-window.html.en#window-layout-spacing
> 
> If you're redoing all this storage UI, it seems like a pretty good time

Well, Im just touching the partition_gui.py file "customization" but
this is a very good observation.

> to start doing things like this.
> 
> Otherwise, patch looks fine.
> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

Attachment: pgp2ivgOj5bbF.pgp
Description: PGP signature

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux