On Thu, Sep 17, 2009 at 09:17:00AM -0400, Chris Lumens wrote:
> > diff --git a/scripts/makeupdates b/scripts/makeupdates
> > index 465e9b6..e3e1922 100755
> > --- a/scripts/makeupdates
> > +++ b/scripts/makeupdates
> > @@ -205,7 +205,8 @@ def main(argv):
> > ['tag=', 'offset=',
> > 'keep', 'compile', 'help'])
> > except getopt.GetoptError:
> > - help = True
> > + usage(prog)
> > + sys.exit(1)
> >
> > for o, a in opts:
> > if o in ('-k', '--keep'):
>
> Setting opts = [] at the beginning of main would probably be more in the
> style of this file.
Thats another way of doing it ;) and it works well, lets push that.
>
> Other than that, these three all look fine - as long as you've given the
> iutil one in particular a really good workout.
>
> - Chris
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
Attachment:
pgpaGROq15EJ1.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
