Re: [PATCH 2/3] If we cant parse the options, opts will probably be None anyway.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> diff --git a/scripts/makeupdates b/scripts/makeupdates
> index 465e9b6..e3e1922 100755
> --- a/scripts/makeupdates
> +++ b/scripts/makeupdates
> @@ -205,7 +205,8 @@ def main(argv):
>                                     ['tag=', 'offset=',
>                                      'keep', 'compile', 'help'])
>      except getopt.GetoptError:
> -        help = True
> +        usage(prog)
> +        sys.exit(1)
>  
>      for o, a in opts:
>          if o in ('-k', '--keep'):

Setting opts = [] at the beginning of main would probably be more in the
style of this file.

Other than that, these three all look fine - as long as you've given the
iutil one in particular a really good workout.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux