Re: [PATCH] Make the messages consistent with starting First Aid Kit menu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm not the Official Anaconda Error Message Editor, but I've got a
couple comments.

The one problem is that we're past the string freeze now so we can't
really change them, but you can certainly commit to a local branch and
then cherry-pick over once we have a new development branch open.

> @@ -282,8 +282,8 @@ def runRescue(anaconda, instClass):
>                "read-only instead of read-write by choosing 'Read-Only'."
>                "\n\n"
>                "If for some reason this process fails you can choose 'Skip' "
> -              "and this step will be skipped and you will go directly to a "
> -              "command shell.\n\n") % (anaconda.rootPath,),
> +              "and this step will be skipped and you will go directly to the "
> +              "interactive rescue environment.\n\n") % (anaconda.rootPath,),
>                [_("Continue"), _("Read-Only"), _("Skip")] )
>  
>          if rc == string.lower(_("Skip")):

I'd probably change this to say "If this process fails you can choose
'Skip' to go directly to a command shell.".  I don't like the "blah and
blah and blah" approach of the current message.

> @@ -344,10 +344,10 @@ def runRescue(anaconda, instClass):
>                  else:
>                      ButtonChoiceWindow(screen, _("Rescue"),
>                          _("Your system had dirty file systems which you chose not "
> -                          "to mount.  Press return to get a shell from which "
> +                          "to mount.  Press return to enter the rescue environment from which "
>                            "you can fsck and mount your partitions.  The system "
> -                          "will reboot automatically when you exit from the "
> -                          "shell."), [_("OK")], width = 50)
> +                          "will reboot automatically when you exit from it "
> +                          ), [_("OK")], width = 50)
>                  rootmounted = 0
>              else:
>                  if anaconda.isKickstart:

I'd leave off the "from it" and just have the sentence end "...will
automatically reboot when you exit."  This comment applies to all the
other hunks, too.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux