On 07/08/2009 05:21 PM, David Lehman wrote:
# Ignore partitions found on the raw disks which are part of a
- # dmraidset
- for set in self.getDevicesByType("dm-raid array"):
+ # biosraidset
+ sets = self.getDevicesByType("dm-raid array")
+ sets[len(sets):] = self.getDevicesByType("mdcontainer")
For readability, it would be nice to change this to:
sets.extend(self.getDevicesByType("mdcontainer"))
I tried that but if both the sets are empty, extend
returns None instead of [] (yeah that sucks).
List.extend modifies the list in-place, so the return value is always
None. If you use the exact line I used above, sets should end up with
the expected value. I just did a little test on python-2.6-9 to make
sure.
Ah, that is what I was doing wrong :)
Thanks, fixed and the patches are pushed.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
