Re: [PATCH 2/4] When all udev_is-foo() checks fail return instead of backtracing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-07-08 at 15:56 +0200, Hans de Goede wrote:
> While testing isw bios raid using mdraid, I hit a backtrace caused
> by all udev_is-foo() checks failing. This pathc logs an error and
> ignores the device instead of backtracing. I believe this may work
> around quite a few "'NoneType' object has no attribute Name" bugs we
> have open at the moment.

Looks good with the exception of a little typo, below.

> ---
>  storage/devicetree.py |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/storage/devicetree.py b/storage/devicetree.py
> index 08846f3..d91fcba 100644
> --- a/storage/devicetree.py
> +++ b/storage/devicetree.py
> @@ -1279,6 +1279,9 @@ class DeviceTree(object):
>              log.debug("%s is a partition" % name)
>              if device is None:
>                  device = self.addUdevPartitionDevice(info)
> +        else:
> +            log.error("Unknow block device type for: %s" % name)

                          Unknown

> +            return
>  
>          # If this device is protected, mark it as such now. Once the tree
>          # has been populated, devices' protected attribute is how we will

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux