Re: [PATCH 4/4] Add support for biosraid using mdadm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >>           # Ignore partitions found on the raw disks which are part of a
> >> -        # dmraidset
> >> -        for set in self.getDevicesByType("dm-raid array"):
> >> +        # biosraidset
> >> +        sets = self.getDevicesByType("dm-raid array")
> >> +        sets[len(sets):] = self.getDevicesByType("mdcontainer")
> >
> > For readability, it would be nice to change this to:
> >
> >   sets.extend(self.getDevicesByType("mdcontainer"))
> >
> 
> I tried that but if both the sets are empty, extend
> returns None instead of [] (yeah that sucks).

List.extend modifies the list in-place, so the return value is always
None. If you use the exact line I used above, sets should end up with
the expected value. I just did a little test on python-2.6-9 to make
sure.

Dave

> 
> Regards,
> 
> Hans
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux