On Fri, Mar 27, 2009 at 07:25:07PM +0100, Hans de Goede wrote:
> Hi,
>
> It would have been helpful to somehow mention that this is a
> *pyblock* patch :)
yep, need to get better at doing this ;)
>
> Anyways looks good!
>
> Regards,
>
> hans
>
>
> On 03/27/2009 07:02 PM, Joel Granados Moreno wrote:
>> Previously, we were returning the set as soon as we found it, ignoring
>> other sets that might be present. This patch corrects this behavior.
>> ---
>> __init__.py | 9 +++++----
>> 1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/__init__.py b/__init__.py
>> index 79ab684..c6449a6 100644
>> --- a/__init__.py
>> +++ b/__init__.py
>> @@ -362,15 +362,16 @@ def getRaidSetFromRelatedMem(uuid=None, major=None, minor=None, name=None):
>> uuid and name are strings. major and minor are converted to long before
>> being compared. name is the dev name without the path.
>>
>> - Returns a string.
>> - Returns None if no set is related to the specified device.
>> + Returns a list of sets.
>> + Returns an empty list if no set is related to the specified device.
>> """
>> + retval = []
>> kwargs = {"uuid":uuid, "name":name, "major":major, "minor":minor}
>> for rs in getRaidSets():
>> if getMemFromRaidSet(rs, **kwargs) != None:
>> - return rs
>> + retval.append(rs)
>>
>> - return None
>> + return retval
>>
>> __all__ = [ "dm", "dmraid", "BlockDev" ]
>>
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
--
Joel Andres Granados
Brno, Czech Republic, Red Hat.
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
