On Fri, Mar 27, 2009 at 07:26:50PM +0100, Hans de Goede wrote: > > > On 03/27/2009 07:00 PM, Joel Granados Moreno wrote: >> We were erroneously assuming that there could only exist one RaidSet on >> top of a group of underlying devs. This patch corrects this assumption >> by allowing anaconda to see a dynamic number of sets. > > Hi, > > Thanks for taking care of this! Patch looks good, only one remark, we should > no longer be ignoring the member disk when we are ignoring a set, otherwise This is very true. I wonder if there are any unseen bugs with just not ignoring the member disks at all. Will work on this later today. thx for the review. > if there are 2 sets of which we ignore only one, after a storage reset (which > can happen during partitioning setup), we will no longer find the non ignored > set. > > Regards, > > Hans > >> --- >> storage/devicetree.py | 115 +++++++++++++++++++++++++------------------------ >> + # are not really using it. Commenting this out until .... >> + # we really need it. >> + #device.format.raidmem = block.getMemFromRaidSet(dm_array, >> + # major=major, minor=minor, uuid=uuid, name=name) >> + except DeviceUserDeniedFormatError: >> + # We should ignore the dmriad and its components >> + self.addIgnoredDisk(rs.name) >> + self.addIgnoredDisk(device.name) >> + rs.deactivate() >> elif format.type == "lvmpv": >> # lookup/create the VG and LVs >> try: > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list -- Joel Andres Granados Brno, Czech Republic, Red Hat. _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
