On 03/19/2009 11:14 AM, Jeremy Katz wrote:
isys.umount() defaults to removing directories. Maybe we should change
that, but it has implications for a fair number of callers. So let's just
not remove the mountpoints for now
Fine with this patch.
I'm not in favor of changing the behavior of isys.umount() right now
since it's used all over the place. I'm now relying on the removeDir
capability when getting existing filesystem size.
---
storage/formats/fs.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/storage/formats/fs.py b/storage/formats/fs.py
index 71160bb..c624c59 100644
--- a/storage/formats/fs.py
+++ b/storage/formats/fs.py
@@ -508,7 +508,7 @@ class FS(DeviceFormat):
if not os.path.exists(self._mountpoint):
raise FSError("mountpoint does not exist")
- rc = isys.umount(self._mountpoint)
+ rc = isys.umount(self._mountpoint, removeDir = False)
if rc:
raise FSError("umount failed")
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
