Re: [PATCH] Let's not remove our mountpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> isys.umount() defaults to removing directories.  Maybe we should change
> that, but it has implications for a fair number of callers.  So let's just
> not remove the mountpoints for now
> ---
>  storage/formats/fs.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/storage/formats/fs.py b/storage/formats/fs.py
> index 71160bb..c624c59 100644
> --- a/storage/formats/fs.py
> +++ b/storage/formats/fs.py
> @@ -508,7 +508,7 @@ class FS(DeviceFormat):
>          if not os.path.exists(self._mountpoint):
>              raise FSError("mountpoint does not exist")
>  
> -        rc = isys.umount(self._mountpoint)
> +        rc = isys.umount(self._mountpoint, removeDir = False)
>          if rc:
>              raise FSError("umount failed")

Good one.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux