On Thursday, March 19 2009, David Cantrell said: > On 03/19/2009 11:14 AM, Jeremy Katz wrote: >> isys.umount() defaults to removing directories. Maybe we should change >> that, but it has implications for a fair number of callers. So let's just >> not remove the mountpoints for now > > Fine with this patch. > > I'm not in favor of changing the behavior of isys.umount() right now > since it's used all over the place. I'm now relying on the removeDir > capability when getting existing filesystem size. Yeah, clearly if we change the semantics, we'll need to go through and change other callers instead. But from the principle of least surprise, that might be worth doing post-beta. Given that it's grep'able, it shouldn't be too bad. Then again, that's the way the method has worked forever and this is the first time I can think of that we've tripped over it, so maybe it's less of a problem :) Jeremy _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
