Moray Henderson (ICT) wrote:
Ah - it looks as if the bug I just found in the CentOS 5.1 version of anaconda is still present here. If you have a CDPATH set and run buildinstall using a relative root path, DIR will end up with two lines. It doesn't look as bad here as in the old version (where DIR immediately got deleted!), but I would recommend
--- a/scripts/buildinstall 2008-02-19 22:54:02.000000000 +0000
+++ b/scripts/buildinstall 2008-02-21 10:32:27.000000000 +0000
@@ -86,7 +86,7 @@
BUGURL="your distribution provided bug reporting tool."
fi
-DIR=`cd $DIR; /bin/pwd`
+DIR=`cd $DIR > /dev/null; /bin/pwd`
BUILDINSTDIR=`mktemp -d ${TMPDIR:-/tmp}/buildinstall.tree.XXXXXX`
TREEDIR=`mktemp -d ${TMPDIR:-/tmp}/treedir.XXXXXX`
Moray.
"To err is human. To purr, feline"
http://members.aol.com/edgwddirk
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
I don't see the harm in this patch. Additionally it ensures the correct execution of buildinstall in environments with the CDPATH set. applied :)
thx.
--
Joel Andres Granados
Red Hat / Brno, Czech Republic
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
