Digging into bug 191381

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Well, I looked at this a bit and came up with the following path
(attached).  It's straightforward enough.

I was wondering about a few things that I saw along the way.

First, unmountCD() seems to be particular to the CD installation
method, but it's present in all of the methods... it seems to me
that it really should be an internally used (private) helper
function leveraged by other less-media-specific methods.

Which is partly the case:  filesDone() is more generic, and indeed
duplicates some of the functionality of unmountCD().

So how about we make filesDone() call unmountCD() in the CD
method, and remove all other references to unmountCD() in
the other classes and in the base class?

I'm seeing a couple of other issues...  I'll post more about then in
another message, but basically I'm using:

# X Window System configuration information
xconfig --driver "radeon" --videoram 32768 --resolution 1400x1050
--depth 24 --startxonboot --defaultdesktop gnome
# System monitor
monitor --noprobe --monitor "LCD Panel 1400x1050"

in the ks.cfg, but the resulting anaconda-ks.cfg tells me:

monitor --hsync ...
xconfig --driver "radeon" --videoram 32768 --resolution "800x600" ...

I'll try again in graphical mode, because certain things don't seem to have
taken (like the keyboard type and system language, etc).

-Philip

--- installmethod.py.bak	2005-11-16 17:37:08.000000000 -0700
+++ installmethod.py	2006-05-12 15:44:20.000000000 -0600
@@ -103,6 +103,7 @@
 # (ie immediately before the congratulations screen).  main use right now
 # is ejecting the cdrom
 def doMethodComplete(method, fsset):
+    method.filesDone()
     method.ejectCD()
 
     mtab = "/dev/root / ext3 ro 0 0\n"
--- yuminstall.py.bak	2006-03-13 09:50:57.000000000 -0700
+++ yuminstall.py	2006-05-12 15:45:15.000000000 -0600
@@ -995,7 +995,6 @@
         if not cb.beenCalled:
             cb.initWindow.pop()
 
-        self.method.filesDone()
         self.instLog.close ()
 
         id.instProgress = None

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux