[PATCH v2 0/3] xfsprogs: xfs_quota foreign fs path handling modifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello-

This is version 2 of a series that supercedes:
http://www.spinics.net/lists/xfs/msg42220.html -
(xfs_quota foreign fs path handling changes).

The following commits modified xfs_quota for use on foreign
filesystems:
b20b6c2 xfs_quota: certain commands must always be available
29647c8 xfs_quota: add capabilities for use on non-XFS filesystems

Included in those commits were modifications to
fs_initialise_mounts (paths.c), resulting in a reverse
compatibility issue. In particular, xfstest xfs/261 failed,
due to foreign fs paths being picked up from the fs table,
and the xfs_quota print command complaining about not being
able to print the foreign paths.

This series fixes the foreign path print problem, via
modifications to the xfs_quota paths and print operations.

patch 1: populate the fs table with xfs entries first,
maintaining mtab order, followed by foreign fs entries.

patch 2: adjust print and path formatting of xfs and
foreign fs entries, maintaining reverse compatibility.

patch 3: add the case for foreign fs in init_check_command
to cover both states of the -f (foreign_allowed) flag.

------
history:
v2: patch 1: -Improve commit message.
             -Align xfs_fs_count declaration and add it to path.h.
             -Correct src and dest initializations in memmove
              in fs_table_insert (fix valgrind error).
             -Remove unnecessary iterative loop in path_f.
             -Add iterative loop in print_f (break if foreign fs
              encountered and !foreign_allowed).
             -Correct path_f to use xfs_fs_count when !foreign_allowed.

    patch 2: -Simplify formatting logic for print and path.

    patch 3: -no changes.

v1: http://www.spinics.net/lists/xfs/msg42399.html
------

Again, Questions/comments are welcome.

Thanks-
Bill

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs



[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux