On Fri, Jun 03, 2016 at 07:56:08PM +0200, Stefan Priebe - Profihost AG wrote: > Hi, > > should i remove the complete if conditions incl. the return 0 or should > id convert it to if without WARN_ONCE? like below? > > if (WARN_ON_ONCE(delalloc)) > return 0; > if (WARN_ON_ONCE(unwritten)) > return 0; > > => > > if (delalloc) > return 0; > if (unwritten) > return 0; Yes, you need to keep the checks and returns. That's what I meant when I said that "XFS handles the dirty page case correctly in this case". If the page is dirty, we should not be attempting to release the buffers, and that is what the code does. It's just noisy about it... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
