On 06/03/16 19:56, Stefan Priebe - Profihost AG wrote: > Hi, > > should i remove the complete if conditions incl. the return 0 or should > id convert it to if without WARN_ONCE? like below? > > if (WARN_ON_ONCE(delalloc)) > return 0; > if (WARN_ON_ONCE(unwritten)) > return 0; > > => > > if (delalloc) > return 0; > if (unwritten) > return 0; Good thing you ask, I forgot about the returns.. Until the bigger picture has been figured out with -mm I'd probably keep the returns. -h _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs