On Wed, Apr 06, 2016 at 07:39:21PM +0300, Alex Lyakas wrote: > Hello Dave, > > Thank you for your response. We understand your concerns and will do > further testing with the vmalloc alternative. > > Meanwhile, I found another issue happening when files have many > extents. When unmounting XFS, we call > xfs_inode_free => xfs_idestroy_fork => xfs_iext_destroy > This goes over the whole indirection array and calls > xfs_iext_irec_remove for each one of the erps (from the last one to > the first one). As a result, we keep shrinking (reallocating > actually) the indirection array until we shrink out all of its > elements. When we have files with huge numbers of extents, umount > takes 30-80 sec, depending on the amount of files that XFS loaded > and the amount of indirection entries of each file. The unmount > stack looks like [1]. > > That patch in [2] seems to address the issue. Do you think it is > reasonable? It was tested only on kernel 3.18.19. Looks like a good optimisation to make. Can you send it as proper patch (separate thread) with this description and your signed-off-by on it? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
