On Wed, Apr 06, 2016 at 01:56:57PM +0300, Dan Carpenter wrote: > Hello Darrick J. Wong, > > The patch 5110cd82ca90: "xfs: use named array initializers for log > item dumping" from Mar 7, 2016, leads to the following static checker > warning: > > fs/xfs/xfs_log.c:2085 xlog_print_tic_res() > error: buffer overflow 'trans_type_str' 43 <= 43 > > fs/xfs/xfs_log.c > 2080 > 2081 xfs_warn(mp, "xlog_write: reservation summary:"); > 2082 xfs_warn(mp, " trans type = %s (%u)", > 2083 ((ticket->t_trans_type <= 0 || > 2084 ticket->t_trans_type > XFS_TRANS_TYPE_MAX) ? > ^ > Should be >=. Why is zero invalid? > > 2085 "bad-trans-type" : trans_type_str[ticket->t_trans_type]), > 2086 ticket->t_trans_type); > 2087 xfs_warn(mp, " unit res = %d bytes", I just pushed patches to the for-next branch (i.e. linux-next) that remove this code. https://git.kernel.org/cgit/linux/kernel/git/dgc/linux-xfs.git/commit/?h=for-next&id=710b1e2c2948c1e5d0499def5273ecbc6472342d Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
