On Thu, Mar 10, 2016 at 06:19:13AM -0800, Christoph Hellwig wrote: > On Tue, Mar 08, 2016 at 03:16:07PM +1100, Dave Chinner wrote: > > From: "Darrick J. Wong" <darrick.wong@xxxxxxxxxx> > > > > For the rmap btree to work, we have to fed the extent owner > > s/fed/feed/ <nod> > > > +/* > > + * Ownership info for an extent. This is used to create reverse-mapping > > + * entries. > > + */ > > +#define XFS_RMAP_INO_ATTR_FORK (1) > > +#define XFS_RMAP_BMBT_BLOCK (2) > > These are OR-able flags - it might make sense to define them as: > > #define XFS_RMAP_INO_ATTR_FORK (1 << 0) > #define XFS_RMAP_BMBT_BLOCK (1 << 1) > > to make this more obvious. Ok. Will do when I merge the "separate xfs_rmap_irec flags field" patch into the appropriate patches (like this one). --D > > _______________________________________________ > xfs mailing list > xfs@xxxxxxxxxxx > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs