> -----Original Message----- > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@xxxxxxxxxxxx] On Behalf Of > Ross Zwisler > Sent: Wednesday, December 23, 2015 1:39 PM > Subject: [PATCH v6 3/7] mm: add find_get_entries_tag() > ... > diff --git a/mm/filemap.c b/mm/filemap.c ... > +unsigned find_get_entries_tag(struct address_space *mapping, pgoff_t start, > + int tag, unsigned int nr_entries, > + struct page **entries, pgoff_t *indices) > +{ > + void **slot; > + unsigned int ret = 0; ... > + radix_tree_for_each_tagged(slot, &mapping->page_tree, > + &iter, start, tag) { ... > + indices[ret] = iter.index; > + entries[ret] = page; > + if (++ret == nr_entries) > + break; > + } Using >= would provide more safety from buffer overflow problems in case ret ever jumped ahead by more than one. --- Robert Elliott, HPE Persistent Memory _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
