On Wed, Aug 12, 2015 at 11:52:58PM -0700, Christoph Hellwig wrote: > On Thu, Aug 13, 2015 at 11:32:44AM +1000, Dave Chinner wrote: > > > http://thread.gmane.org/gmane.comp.file-systems.xfs.general/39030/focus=39009 > > > > I completely forgot you did this. I'll go back and look at it > > and see what I can pull from it. Thanks for the reminder, Christoph. > > As far as I can tell your new version is superior in all aspects > except for the patch split :) Ok, I've gone back and had a look at this now and reminded myself of the discussion we had and the problems found. The end results are remarkably similar - maybe that's why I found it easy to write this patch set. i.e. your patchset was buried somewhere in my brain, even though I'd forgotten about it at the surface... How would you like to see this patchset broken up into more sensible/reviewable chunks? It's just folding and splitting patches, so it's not a big deal to rework it... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs