> STATIC int > xlog_recover_process_efis( > - struct xlog *log) > + struct xlog *log, > + bool cancel) There is almost no code shared between cancelation and processing, so please add a new xlog_cancel_efis helper instead. > + efip = (struct xfs_efi_log_item *) lip; Please use container_of to get to a containing structure. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs