> + error = xfs_efi_copy_format(&(item->ri_buf[0]), &(efip->efi_format)); > + if (error) { > xfs_efi_item_free(efip); Shou;dn't we switch all users of xfs_item_free except for xfs_efi_release to xfs_efi_release now for consistency? _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs